This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
Fix issues with deploy:Registrar and deploy:AngelProtocol
#215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xNeshi
changed the title
deploy:Registrardeploy:Registrar and deploy:AngelProtocol
tasks/deploy/deployAngelProtocol.ts
Outdated
| @@ -71,7 +71,7 @@ task("deploy:AngelProtocol", "Will deploy complete Angel Protocol") | |||
|
|
|||
| const gasFwd = await deployGasFwd( | |||
| { | |||
| deployer: deployer, | |||
| deployer: proxyAdmin, | |||
There was a problem hiding this comment.
I think this should be APTeamMultisig. See my longer comment in my PR
Comment on lines
+7
to
+11
| export enum NetworkConnectionAction { | ||
| NONE, | ||
| POST, | ||
| DELETE, | ||
| } |
There was a problem hiding this comment.
Isn't this a type not a constant?
There was a problem hiding this comment.
Enums in TS are actually objects (like many things in JS/TS it's confusing, I know).
https://www.typescriptlang.org/docs/handbook/enums.html#enums-at-runtime
Since we have many enums we need to create, we can store them in a separate enums.ts file?
There was a problem hiding this comment.
That sounds like a good idea! Thanks for the info
stevieraykatz
approved these changes
Jul 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of the solution
IndexFund > registrarContractupdateGasFwdFactory > registrarupdateGasFwdFactoryshould beproxyAdmin(currentlydeployer)LocalRegistrar.updateNetworkConnectionsshould useenum NetworkConnectionActionfor itsactionparamInstructions on making this work
yarnoryarn installto install npm dependenciesyarn testto verify all tests still passnpx hardhat nodeyarn deploy --network localhost --yesnpx hardhat deploy:Registrar --network localhost --yes